in RecordConnectionFailed, don't shout very loud if we deliberately burned the pipe

StackExchange.Redis.Tests/Issues/Issue182.cs

@@ -45,7 +45,7 @@ public async Task SetMembers()
         [FactLongRunning]
         public async Task SetUnion()
         {
-            using (var conn = Create())
+            using (var conn = Create(syncTimeout: 10000))
             {
                 var db = conn.GetDatabase();
 

StackExchange.Redis/StackExchange/Redis/CompletionManager.cs

@@ -15,6 +15,7 @@ internal sealed partial class CompletionManager
 
         internal static void CompleteSyncOrAsyncImpl(CompletionManager manager, ICompletable operation)
         {
+            if (operation == null) return;
             if (manager != null) manager.PerInstanceCompleteSyncOrAsync(operation);
             else SharedCompleteSyncOrAsync(operation);
         }
@@ -32,7 +33,6 @@ public CompletionManager(ConnectionMultiplexer multiplexer, string name)
 
         private static void SharedCompleteSyncOrAsync(ICompletable operation)
         {
-            if (operation == null) return;
             if (!operation.TryComplete(false))
             {
                 SocketManager.Shared.ScheduleTask(s_AnyOrderCompletionHandler, operation);
@@ -40,7 +40,6 @@ private static void SharedCompleteSyncOrAsync(ICompletable operation)
         }
         private void PerInstanceCompleteSyncOrAsync(ICompletable operation)
         {
-            if (operation == null) return;
             if (operation.TryComplete(false))
             {
                 multiplexer.Trace("Completed synchronously: " + operation, name);

StackExchange.Redis/StackExchange/Redis/PhysicalBridge.cs

@@ -97,6 +97,8 @@ public void Dispose()
         }
         ~PhysicalBridge()
         {
+            isDisposed = true; // make damn sure we don't true to resurrect
+
             // shouldn't *really* touch managed objects
             // in a finalizer, but we need to kill that socket,
             // and this is the first place that isn't going to

StackExchange.Redis/StackExchange/Redis/PhysicalConnection.cs

@@ -242,6 +242,7 @@ internal void Shutdown()
             if (ioPipe != null)
             {
                 Trace("Disconnecting...");
+                try { BridgeCouldBeNull?.OnDisconnected(ConnectionFailureType.ConnectionDisposed, this, out _, out _); } catch { }
                 try { ioPipe.Input?.CancelPendingRead(); } catch { }
                 try { ioPipe.Input?.Complete(); } catch { }
                 try { ioPipe.Output?.CancelPendingFlush(); } catch { }
@@ -291,9 +292,12 @@ public Task FlushAsync()
 
         public void RecordConnectionFailed(ConnectionFailureType failureType, Exception innerException = null, [CallerMemberName] string origin = null)
         {
+
             Exception outerException = innerException;
             IdentifyFailureType(innerException, ref failureType);
 
+            if (_ioPipe != null) // if *we* didn't burn the pipe: flag it
+            {
                 if (failureType == ConnectionFailureType.InternalFailure) OnInternalError(innerException, origin);
 
                 // stop anything new coming in...
@@ -367,7 +371,7 @@ void add(string lk, string sk, string v)
 
                     BridgeCouldBeNull?.OnConnectionFailed(this, failureType, outerException);
                 }
-
+            }
             // cleanup
             lock (_writtenAwaitingResponse)
             {