Cleanup: misc tests

StackExchange.Redis.Tests/Booksleeve/Locking.cs

@@ -20,7 +20,7 @@ public void AggressiveParallel()
             using (var c1 = GetUnsecuredConnection(waitForOpen: true))
             using (var c2 = GetUnsecuredConnection(waitForOpen: true))
             {
-                WaitCallback cb = obj =>
+                void cb(object obj)
                 {
                     var conn = (ConnectionMultiplexer)obj;
                     conn.InternalError += (o, e) =>
@@ -41,7 +41,7 @@ public void AggressiveParallel()
                     db.Ping();
                     conn.Close(false);
                     if (Interlocked.Decrement(ref count) == 0) evt.Set();
-                };
+                }
                 ThreadPool.QueueUserWorkItem(cb, c1);
                 ThreadPool.QueueUserWorkItem(cb, c2);
                 evt.WaitOne(8000);

StackExchange.Redis.Tests/Booksleeve/PubSub.cs

@@ -182,7 +182,7 @@ public void Issue38()
             {
                 var sub = pub.GetSubscriber();
                 int count = 0;
-                Action<RedisChannel, RedisValue> handler = (channel, payload) => Interlocked.Increment(ref count);
+                void handler(RedisChannel channel, RedisValue payload) => Interlocked.Increment(ref count);
                 var a0 = sub.SubscribeAsync("foo", handler);
                 var a1 = sub.SubscribeAsync("bar", handler);
                 var b0 = sub.SubscribeAsync("f*o", handler);

StackExchange.Redis.Tests/ConnectFailTimeout.cs

@@ -29,7 +29,7 @@ public async Task NoticesConnectFail()
                 Assert.Throws<RedisConnectionException>(() => server.Ping());
 
                 // Heartbeat should reconnect by now
-                await Task.Delay(5000);
+                await Task.Delay(5000).ConfigureAwait(false);
 
                 var time = server.Ping();
                 Output.WriteLine(time.ToString());

StackExchange.Redis.Tests/GlobalSuppressions.cs

+
+// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.ConnectionFailedErrors.SSLCertificateValidationError(System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.Booksleeve.PubSub.TestMultipleSubscribersGetMessage")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PubSub.ExplicitPublishMode")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PubSubNonParallel.SubscriptionsSurviveMasterSwitch(System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PubSub.TestBasicPubSubFireAndForget(System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.Booksleeve.PubSub.Issue38")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.SSL.ConnectToSSLServer(System.Boolean,System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PubSub.TestPatternPubSub(System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PubSub.TestBasicPubSub(System.Boolean,System.String,System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.SSL.ConnectToSSLServer(System.Boolean,System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.Booksleeve.PubSub.PubSubOrder~System.Threading.Tasks.Task")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PreserveOrder.Execute(System.Boolean)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.ConnectionShutdown.ShutdownRaisesConnectionFailedAndRestore")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.Issues.BgSaveResponse.ShouldntThrowException(StackExchange.Redis.SaveType)")]
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "<Pending>", Scope = "member", Target = "~M:StackExchange.Redis.Tests.Issues.BgSaveResponse.ShouldntThrowException(StackExchange.Redis.SaveType)")]

StackExchange.Redis.Tests/Issues/BgSaveResponse.cs

@@ -8,9 +8,6 @@ public class BgSaveResponse : TestBase
         public BgSaveResponse(ITestOutputHelper output) : base (output) { }
 
         [Theory (Skip = "We don't need to test this, and it really screws local testing hard.")]
-#pragma warning disable 0618
-        //[InlineData(SaveType.ForegroundSave)]
-#pragma warning restore 0618
         [InlineData(SaveType.BackgroundSave)]
         [InlineData(SaveType.BackgroundRewriteAppendOnlyFile)]
         public void ShouldntThrowException(SaveType saveType)

StackExchange.Redis.Tests/Issues/Issue791.cs

@@ -7,7 +7,6 @@ public class Issue791 : TestBase
     {
         public Issue791(ITestOutputHelper output) : base(output) { }
 
-        
         [Fact]
         public void PreserveAsyncOrderImplicitValue_ParsedFromConnectionString()
         {
@@ -20,7 +19,6 @@ public void PreserveAsyncOrderImplicitValue_ParsedFromConnectionString()
             Assert.Equal("preserveAsyncOrder=False", options.ToString());
         }
 
-
         [Fact]
         public void DefaultValue_IsTrue()
         {
@@ -28,7 +26,6 @@ public void DefaultValue_IsTrue()
             Assert.True(options.PreserveAsyncOrder);
         }
 
-        
         [Fact]
         public void PreserveAsyncOrder_SetConnectionMultiplexerProperty()
         {

StackExchange.Redis.Tests/Locking.cs

@@ -31,11 +31,11 @@ public void AggressiveParallel(TestMode testMode)
         {
             int count = 2;
             int errorCount = 0;
-            ManualResetEvent evt = new ManualResetEvent(false);
+            var evt = new ManualResetEvent(false);
             using (var c1 = Create(testMode))
             using (var c2 = Create(testMode))
             {
-                WaitCallback cb = obj =>
+                void cb(object obj)
                 {
                     var conn = (IDatabase)obj;
                     conn.Multiplexer.ErrorMessage += delegate { Interlocked.Increment(ref errorCount); };
@@ -46,7 +46,7 @@ public void AggressiveParallel(TestMode testMode)
                     }
                     conn.Ping();
                     if (Interlocked.Decrement(ref count) == 0) evt.Set();
-                };
+                }
                 int db = testMode == TestMode.Twemproxy ? 0 : 2;
                 ThreadPool.QueueUserWorkItem(cb, c1.GetDatabase(db));
                 ThreadPool.QueueUserWorkItem(cb, c2.GetDatabase(db));

StackExchange.Redis.Tests/PubSub.cs

@@ -256,7 +256,6 @@ public void TestPatternPubSub(bool preserveOrder)
         [Fact]
         public void SubscriptionsSurviveConnectionFailure()
         {
-            
             using (var muxer = Create(allowAdmin: true))
             {
                 RedisChannel channel = Me();
@@ -284,6 +283,7 @@ public void SubscriptionsSurviveConnectionFailure()
         }
 #endif
     }
+
     internal static class VolatileWrapper
     {
         public static int Read(ref int location)

StackExchange.Redis.Tests/Scans.cs

@@ -37,7 +37,8 @@ public void KeysScan(bool supported)
             }
         }
 
-        private void ScansIScanning()
+        [Fact]
+        public void ScansIScanning()
         {
             using (var conn = Create(allowAdmin: true))
             {
@@ -83,7 +84,8 @@ private void ScansIScanning()
             }
         }
 
-        private void ScanResume()
+        [Fact]
+        public void ScanResume()
         {
             using (var conn = Create(allowAdmin: true))
             {