Test todo builder (#17)

* Changed class to match filename.

* Implement Builder Pattern for ToDoItems in tests, and adjust EfRepositoryShould to use it.

* Move test utility classes to root of Tests project.

* Using ToDoItemBuilder in other ToDo tests.

* Complete ToDoItemBuilder by adding other ToDoItem field methods.

tests/CleanArchitecture.Tests/Core/Entities/ToDoItemMarkCompleteShould.cs

-using CleanArchitecture.Core.Entities;
-using CleanArchitecture.Core.Events;
+using CleanArchitecture.Core.Events;
 using System.Linq;
 using Xunit;
 
@@ -10,7 +9,7 @@ namespace CleanArchitecture.Tests.Core.Entities
         [Fact]
         public void SetIsDoneToTrue()
         {
-            var item = new ToDoItem();
+            var item = new ToDoItemBuilder().Build();
 
             item.MarkComplete();
 
@@ -20,7 +19,7 @@ namespace CleanArchitecture.Tests.Core.Entities
         [Fact]
         public void RaiseToDoItemCompletedEvent()
         {
-            var item = new ToDoItem();
+            var item = new ToDoItemBuilder().Build();
 
             item.MarkComplete();
 

tests/CleanArchitecture.Tests/Integration/Data/EfRepositoryShould.cs

-using System;
+using CleanArchitecture.Core.Entities;
+using CleanArchitecture.Core.Interfaces;
+using CleanArchitecture.Infrastructure.Data;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
-using Xunit;
-using CleanArchitecture.Infrastructure.Data;
-using CleanArchitecture.Core.Entities;
-using System.Linq;
-using CleanArchitecture.Core.Events;
-using CleanArchitecture.Core.Interfaces;
 using Moq;
+using System;
+using System.Linq;
+using Xunit;
 
 namespace CleanArchitecture.Tests.Integration.Data
 {
-    public class EfRepositoryAddShould
+    public class EfRepositoryShould
     {
         private AppDbContext _dbContext;
 
         private static DbContextOptions<AppDbContext> CreateNewContextOptions()
         {
-            // Create a fresh service provider, and therefore a fresh 
+            // Create a fresh service provider, and therefore a fresh
             // InMemory database instance.
             var serviceProvider = new ServiceCollection()
                 .AddEntityFrameworkInMemoryDatabase()
@@ -36,15 +35,14 @@ namespace CleanArchitecture.Tests.Integration.Data
         public void AddItemAndSetId()
         {
             var repository = GetRepository();
-            var item = new ToDoItem();
+            var item = new ToDoItemBuilder().Build();
 
             repository.Add(item);
 
             var newItem = repository.List().FirstOrDefault();
 
             Assert.Equal(item, newItem);
-            Assert.True(newItem.Id > 0);
-
+            Assert.True(newItem?.Id > 0);
         }
 
         [Fact]
@@ -53,27 +51,27 @@ namespace CleanArchitecture.Tests.Integration.Data
             // add an item
             var repository = GetRepository();
             var initialTitle = Guid.NewGuid().ToString();
-            var item = new ToDoItem()
-            {
-                Title = initialTitle
-            };
+            var item = new ToDoItemBuilder().Title(initialTitle).Build();
+
             repository.Add(item);
-            
+
             // detach the item so we get a different instance
             _dbContext.Entry(item).State = EntityState.Detached;
 
             // fetch the item and update its title
             var newItem = repository.List()
                 .FirstOrDefault(i => i.Title == initialTitle);
+            Assert.NotNull(newItem);
             Assert.NotSame(item, newItem);
             var newTitle = Guid.NewGuid().ToString();
             newItem.Title = newTitle;
 
             // Update the item
-            repository.Update(newItem);        
+            repository.Update(newItem);
             var updatedItem = repository.List()
                 .FirstOrDefault(i => i.Title == newTitle);
 
+            Assert.NotNull(updatedItem);
             Assert.NotEqual(item.Title, updatedItem.Title);
             Assert.Equal(newItem.Id, updatedItem.Id);
         }
@@ -84,22 +82,17 @@ namespace CleanArchitecture.Tests.Integration.Data
             // add an item
             var repository = GetRepository();
             var initialTitle = Guid.NewGuid().ToString();
-            var item = new ToDoItem()
-            {
-                Title = initialTitle
-            };
+            var item = new ToDoItemBuilder().Title(initialTitle).Build();
             repository.Add(item);
 
             // delete the item
             repository.Delete(item);
 
             // verify it's no longer there
-            Assert.DoesNotContain(repository.List(), 
+            Assert.DoesNotContain(repository.List(),
                 i => i.Title == initialTitle);
         }
 
-
-
         private EfRepository<ToDoItem> GetRepository()
         {
             var options = CreateNewContextOptions();
@@ -109,4 +102,4 @@ namespace CleanArchitecture.Tests.Integration.Data
             return new EfRepository<ToDoItem>(_dbContext);
         }
     }
-}
\ No newline at end of file
+}

tests/CleanArchitecture.Tests/Integration/Web/NoOpDomainEventDispatcher.cs → tests/CleanArchitecture.Tests/NoOpDomainEventDispatcher.cs

 using CleanArchitecture.Core.Interfaces;
 using CleanArchitecture.Core.SharedKernel;
 
-namespace CleanArchitecture.Tests.Integration.Web
+namespace CleanArchitecture.Tests
 {
     public class NoOpDomainEventDispatcher : IDomainEventDispatcher
     {

tests/CleanArchitecture.Tests/ToDoItemBuilder.cs

+using CleanArchitecture.Core.Entities;
+
+namespace CleanArchitecture.Tests
+{
+    public class ToDoItemBuilder
+    {
+        private readonly ToDoItem _todo = new ToDoItem();
+
+        public ToDoItemBuilder Id(int id)
+        {
+            _todo.Id = id;
+            return this;
+        }
+
+        public ToDoItemBuilder Title(string title)
+        {
+            _todo.Title = title;
+            return this;
+        }
+
+        public ToDoItemBuilder Description(string description)
+        {
+            _todo.Description = description;
+            return this;
+        }
+
+        public ToDoItem Build() => _todo;
+    }
+}