Merge pull request #99 from tms/cultural-paramter-filtering

Make parameter filtering truly culture-insensitive

Dapper NET40/SqlMapper.cs

@@ -2055,7 +2055,7 @@ public static void PackListParameters(IDbCommand command, string namePrefix, obj
 
         private static IEnumerable<PropertyInfo> FilterParameters(IEnumerable<PropertyInfo> parameters, string sql)
         {
-            return parameters.Where(p => Regex.IsMatch(sql, @"[?@:]" + p.Name + "([^a-zA-Z0-9_]+|$)", RegexOptions.IgnoreCase | RegexOptions.Multiline));
+            return parameters.Where(p => Regex.IsMatch(sql, @"[?@:]" + p.Name + "([^a-zA-Z0-9_]+|$)", RegexOptions.IgnoreCase | RegexOptions.Multiline | RegexOptions.CultureInvariant));
         }
 
 
@@ -2146,15 +2146,6 @@ private static IEnumerable<PropertyInfo> FilterParameters(IEnumerable<PropertyIn
 
             foreach (var prop in props)
             {
-                if (filterParams)
-                {
-                    if (identity.sql.IndexOf("@" + prop.Name, StringComparison.InvariantCultureIgnoreCase) < 0
-                        && identity.sql.IndexOf(":" + prop.Name, StringComparison.InvariantCultureIgnoreCase) < 0
-                        && identity.sql.IndexOf("?" + prop.Name, StringComparison.InvariantCultureIgnoreCase) < 0)
-                    { // can't see the parameter in the text (even in a comment, etc) - burn it with fire
-                        continue;
-                    }
-                }
                 if (typeof(ICustomQueryParameter).IsAssignableFrom(prop.PropertyType))
                 {
                     il.Emit(OpCodes.Ldloc_0); // stack is now [parameters] [typed-param]

Tests/Tests.cs

@@ -13,6 +13,8 @@
 using System.ComponentModel;
 using Microsoft.CSharp.RuntimeBinder;
 using System.Data.Common;
+using System.Globalization;
+using System.Threading;
 #if POSTGRESQL
 using Npgsql;
 #endif
@@ -2651,6 +2653,16 @@ public void TestDoubleDecimalConversions_SO18228523_Nulls()
             row.D.IsNull();
         }
 
+        public void TestParameterInclusionNotSensitiveToCurrentCulture()
+        {
+            CultureInfo current = Thread.CurrentThread.CurrentCulture;
+            Thread.CurrentThread.CurrentCulture = new CultureInfo("tr-TR");
+
+            connection.Query<int>("select @pid", new { PId = 1 }).Single();
+
+            Thread.CurrentThread.CurrentCulture = current;
+        }
+
         class HasDoubleDecimal
         {
             public double A { get; set; }