Set initial capacity for collections (#1449)

* Set initial capacity for collections
* Revert Massive changes
Co-authored-by: Nick Craver <nrcraver@gmail.com>

Dapper.Contrib/SqlMapperExtensions.cs

@@ -61,7 +61,7 @@ public interface ITableNameMapper
 
         private static readonly ISqlAdapter DefaultAdapter = new SqlServerAdapter();
         private static readonly Dictionary<string, ISqlAdapter> AdapterDictionary
-            = new Dictionary<string, ISqlAdapter>
+            = new Dictionary<string, ISqlAdapter>(6)
             {
                 ["sqlconnection"] = new SqlServerAdapter(),
                 ["sqlceconnection"] = new SqlCeServerAdapter(),

Dapper.Tests.Contrib/TestSuite.Async.cs

@@ -26,7 +26,7 @@ public async Task TypeWithGenericParameterCanBeInsertedAsync()
 
                 Assert.Single(connection.GetAll<GenericType<string>>());
 
-                var objectsToInsert = new List<GenericType<string>>
+                var objectsToInsert = new List<GenericType<string>>(2)
                 {
                     new GenericType<string>
                     {
@@ -83,7 +83,7 @@ public async Task TypeWithGenericParameterCanBeDeletedAsync()
             }
         }
 
-        [Fact] 
+        [Fact]
         public async Task GetAsyncSucceedsAfterDeleteAsyncWhenExplicitKeyPresent()
         {
             using (var connection = GetOpenConnection())
@@ -227,7 +227,7 @@ public async Task BuilderSelectClauseAsync()
                 await connection.DeleteAllAsync<User>().ConfigureAwait(false);
 
                 var rand = new Random(8675309);
-                var data = new List<User>();
+                var data = new List<User>(100);
                 for (var i = 0; i < 100; i++)
                 {
                     var nU = new User { Age = rand.Next(70), Id = i, Name = Guid.NewGuid().ToString() };
@@ -296,7 +296,7 @@ private async Task InsertHelperAsync<T>(Func<IEnumerable<User>, T> helper)
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -334,7 +334,7 @@ private async Task UpdateHelperAsync<T>(Func<IEnumerable<User>, T> helper)
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -379,7 +379,7 @@ private async Task DeleteHelperAsync<T>(Func<IEnumerable<User>, T> helper)
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -404,7 +404,7 @@ public async Task GetAllAsync()
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 

Dapper.Tests.Contrib/TestSuite.cs

@@ -130,7 +130,7 @@ public void TypeWithGenericParameterCanBeInserted()
 
                 Assert.Single(connection.GetAll<GenericType<string>>());
 
-                var objectsToInsert = new List<GenericType<string>>
+                var objectsToInsert = new List<GenericType<string>>(2)
                 {
                     new GenericType<string>
                     {
@@ -380,7 +380,7 @@ private void InsertHelper<T>(Func<IEnumerable<User>, T> helper)
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -418,7 +418,7 @@ private void UpdateHelper<T>(Func<IEnumerable<User>, T> helper)
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -463,7 +463,7 @@ private void DeleteHelper<T>(Func<IEnumerable<User>, T> helper)
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -588,7 +588,7 @@ public void GetAll()
         {
             const int numberOfEntities = 10;
 
-            var users = new List<User>();
+            var users = new List<User>(numberOfEntities);
             for (var i = 0; i < numberOfEntities; i++)
                 users.Add(new User { Name = "User " + i, Age = i });
 
@@ -684,7 +684,7 @@ public void BuilderSelectClause()
             using (var connection = GetOpenConnection())
             {
                 var rand = new Random(8675309);
-                var data = new List<User>();
+                var data = new List<User>(100);
                 for (int i = 0; i < 100; i++)
                 {
                     var nU = new User { Age = rand.Next(70), Id = i, Name = Guid.NewGuid().ToString() };

Dapper.Tests/MiscTests.cs

@@ -301,7 +301,7 @@ public void TestExecuteMultipleCommandStrongType()
             connection.Execute("create table #t(Name nvarchar(max), Age int)");
             try
             {
-                int tally = connection.Execute("insert #t (Name,Age) values(@Name, @Age)", new List<Student>
+                int tally = connection.Execute("insert #t (Name,Age) values(@Name, @Age)", new List<Student>(2)
             {
                 new Student{Age = 1, Name = "sam"},
                 new Student{Age = 2, Name = "bob"}

Dapper.Tests/ParameterTests.cs

@@ -109,7 +109,7 @@ public void AddParameters(IDbCommand command, SqlMapper.Identity identity)
                 AddStructured(command, number_list);
             }
         }
-        
+
         private class IntCustomParam : SqlMapper.ICustomQueryParameter
         {
             private readonly IEnumerable<int> numbers;
@@ -564,7 +564,7 @@ public void SO29533765_DataTableParametersViaDynamicParameters()
 
             var table = new DataTable { TableName = "MyTVPType", Columns = { { "id", typeof(int) } }, Rows = { { 1 }, { 2 }, { 3 } } };
             table.SetTypeName(table.TableName); // per SO29533765
-            IDictionary<string, object> args = new Dictionary<string, object>
+            IDictionary<string, object> args = new Dictionary<string, object>(1)
             {
                 ["ids"] = table
             };
@@ -841,7 +841,7 @@ public void TestAppendingAnonClasses()
         [Fact]
         public void TestAppendingADictionary()
         {
-            var dictionary = new Dictionary<string, object>
+            var dictionary = new Dictionary<string, object>(2)
             {
                 ["A"] = 1,
                 ["B"] = "two"
@@ -891,7 +891,7 @@ public void TestAppendingAListAsDictionary()
         {
             var p = new DynamicParameters();
             var list = new int[] { 1, 2, 3 };
-            var args = new Dictionary<string, object> { ["ids"] = list };
+            var args = new Dictionary<string, object>(1) { ["ids"] = list };
             p.AddDynamicParams(args);
 
             var result = connection.Query<int>("select * from (select 1 A union all select 2 union all select 3) X where A in @ids", p).ToList();
@@ -1187,7 +1187,7 @@ public void SO25297173_DynamicIn()
 insert @table values(6);
 insert @table values(7);
 SELECT value FROM @table WHERE value IN @myIds";
-            var queryParams = new Dictionary<string, object>
+            var queryParams = new Dictionary<string, object>(1)
             {
                 ["myIds"] = new[] { 5, 6 }
             };
@@ -1224,7 +1224,7 @@ public void Test_AddDynamicParametersRepeatedIfParamTypeIsDbStiringShouldWork()
         [Fact]
         public void AllowIDictionaryParameters()
         {
-            var parameters = new Dictionary<string, object>
+            var parameters = new Dictionary<string, object>(1)
             {
                 ["param1"] = 0
             };

Dapper/SqlMapper.cs

@@ -165,7 +165,7 @@ public static int GetCachedSQLCount()
 
         static SqlMapper()
         {
-            typeMap = new Dictionary<Type, DbType>
+            typeMap = new Dictionary<Type, DbType>(37)
             {
                 [typeof(byte)] = DbType.Byte,
                 [typeof(sbyte)] = DbType.SByte,
@@ -380,7 +380,7 @@ public static DbType LookupDbType(Type type, string name, bool demand, out IType
                     && typeof(IEnumerable<IDataRecord>).IsAssignableFrom(type))
                 {
                     var argTypes = type.GetGenericArguments();
-                    if(typeof(IDataRecord).IsAssignableFrom(argTypes[0]))
+                    if (typeof(IDataRecord).IsAssignableFrom(argTypes[0]))
                     {
                         try
                         {
@@ -2438,7 +2438,7 @@ internal static IList<LiteralToken> GetLiteralTokens(string sql)
                 }
                 else
                 { // might still all be accounted for; check the hard way
-                    var positionByName = new Dictionary<string, int>(StringComparer.OrdinalIgnoreCase);
+                    var positionByName = new Dictionary<string, int>(ctorParams.Length, StringComparer.OrdinalIgnoreCase);
                     foreach (var param in ctorParams)
                     {
                         positionByName[param.Name] = param.Position;