make sure System.Data and Microsoft.Data tests can't squabble; record which...

make sure System.Data and Microsoft.Data tests can't squabble; record which Microsoft.Data tests *will never work*

Dapper.Tests/ConstructorTests.cs

@@ -5,8 +5,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("ConstructorTests")]
     public sealed class SystemSqlClientConstructorTests : ConstructorTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("ConstructorTests")]
     public sealed class MicrosoftSqlClientConstructorTests : ConstructorTests<MicrosoftSqlClientProvider> { }
 #endif
 

Dapper.Tests/DataReaderTests.cs

@@ -4,8 +4,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("DataReaderTests")]
     public sealed class SystemSqlClientDataReaderTests : DataReaderTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("DataReaderTests")]
     public sealed class MicrosoftSqlClientDataReaderTests : DataReaderTests<MicrosoftSqlClientProvider> { }
 #endif
 

Dapper.Tests/DecimalTests.cs

@@ -5,8 +5,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("DecimalTests")]
     public sealed class SystemSqlClientDecimalTests : DecimalTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("DecimalTests")]
     public sealed class MicrosoftSqlClientDecimalTests : DecimalTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class DecimalTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/EnumTests.cs

@@ -4,8 +4,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("EnumTests")]
     public sealed class SystemSqlClientEnumTests : EnumTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("EnumTests")]
     public sealed class MicrosoftSqlClientEnumTests : EnumTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class EnumTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/LiteralTests.cs

@@ -3,8 +3,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("LiteralTests")]
     public sealed class SystemSqlClientLiteralTests : LiteralTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("LiteralTests")]
     public sealed class MicrosoftSqlClientLiteralTests : LiteralTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class LiteralTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/MiscTests.cs

@@ -39,8 +39,10 @@ public GenericUriParser(GenericUriParserOptions options)
 
 namespace Dapper.Tests
 {
+    [Collection("MiscTests")]
     public sealed class SystemSqlClientMiscTests : MiscTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("MiscTests")]
     public sealed class MicrosoftSqlClientMiscTests : MiscTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class MiscTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/MultiMapTests.cs

@@ -6,8 +6,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("MultiMapTests")]
     public sealed class SystemSqlClientMultiMapTests : MultiMapTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("MultiMapTests")]
     public sealed class MicrosoftSqlClientMultiMapTests : MultiMapTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class MultiMapTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/ParameterTests.cs

@@ -718,6 +718,8 @@ private class HazSqlGeo
         [Fact]
         public void DBGeography_SO24405645_SO24402424()
         {
+            if (IsMsDataClient) return; // not supported
+
             EntityFramework.Handlers.Register();
 
             connection.Execute("create table #Geo (id int, geo geography, geometry geometry)");
@@ -739,6 +741,8 @@ public void DBGeography_SO24405645_SO24402424()
         [Fact]
         public void SqlGeography_SO25538154()
         {
+            if (IsMsDataClient) return; // not supported
+
             SqlMapper.ResetTypeHandlers();
             connection.Execute("create table #SqlGeo (id int, geo geography, geometry geometry)");
 
@@ -777,6 +781,8 @@ public void NullableSqlGeometry()
         [Fact]
         public void SqlHierarchyId_SO18888911()
         {
+            if (IsMsDataClient) return; // not supported
+
             SqlMapper.ResetTypeHandlers();
             var row = connection.Query<HazSqlHierarchy>("select 3 as [Id], hierarchyid::Parse('/1/2/3/') as [Path]").Single();
             Assert.Equal(3, row.Id);

Dapper.Tests/ProcedureTests.cs

@@ -6,8 +6,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("ProcedureTests")]
     public sealed class SystemSqlClientProcedureTests : ProcedureTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("ProcedureTests")]
     public sealed class MicrosoftSqlClientProcedureTests : ProcedureTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class ProcedureTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/Providers/EntityFrameworkTests.cs

@@ -22,6 +22,8 @@ public EntityFrameworkTests()
         [Fact]
         public void Issue570_DbGeo_HasValues()
         {
+            if (IsMsDataClient) return; // not supported
+
             EntityFramework.Handlers.Register();
             const string redmond = "POINT (-122.1215 47.6740)";
             DbGeography point = DbGeography.PointFromText(redmond, DbGeography.DefaultCoordinateSystemId);
@@ -37,6 +39,8 @@ public void Issue570_DbGeo_HasValues()
         [Fact]
         public void Issue22_ExecuteScalar_EntityFramework()
         {
+            if (IsMsDataClient) return; // not supported
+
             var geo = DbGeography.LineFromText("LINESTRING(-122.360 47.656, -122.343 47.656 )", 4326);
             var geo2 = connection.ExecuteScalar<DbGeography>("select @geo", new { geo });
             Assert.NotNull(geo2);

Dapper.Tests/QueryMultipleTests.cs

@@ -6,8 +6,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("QueryMultipleTests")]
     public sealed class SystemSqlClientQueryMultipleTests : QueryMultipleTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("QueryMultipleTests")]
     public sealed class MicrosoftSqlClientQueryMultipleTests : QueryMultipleTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class QueryMultipleTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/TestBase.cs

@@ -81,6 +81,8 @@ public sealed class MicrosoftSqlClientProvider : SqlServerDatabaseProvider
 
     public abstract class TestBase<TProvider> : IDisposable where TProvider : DatabaseProvider
     {
+        protected bool IsMsDataClient => connection is Microsoft.Data.SqlClient.SqlConnection;
+
         protected DbConnection GetOpenConnection() => Provider.GetOpenConnection();
         protected DbConnection GetClosedConnection() => Provider.GetClosedConnection();
         protected DbConnection _connection;

Dapper.Tests/TransactionTests.cs

@@ -7,8 +7,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("TransactionTests")]
     public sealed class SystemSqlClientTransactionTests : TransactionTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("TransactionTests")]
     public sealed class MicrosoftSqlClientTransactionTests : TransactionTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class TransactionTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/TupleTests.cs

@@ -3,8 +3,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("TupleTests")]
     public sealed class SystemSqlClientTupleTests : TupleTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("TupleTests")]
     public sealed class MicrosoftSqlClientTupleTests : TupleTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class TupleTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider

Dapper.Tests/XmlTests.cs

@@ -4,8 +4,10 @@
 
 namespace Dapper.Tests
 {
+    [Collection("XmlTests")]
     public sealed class SystemSqlClientXmlTests : XmlTests<SystemSqlClientProvider> { }
 #if MSSQLCLIENT
+    [Collection("XmlTests")]
     public sealed class MicrosoftSqlClientXmlTests : XmlTests<MicrosoftSqlClientProvider> { }
 #endif
     public abstract class XmlTests<TProvider> : TestBase<TProvider> where TProvider : DatabaseProvider