Commit 70d38a60 authored by Nick Craver's avatar Nick Craver

Tests: that equation simplifies to zero

The jitter was causing 01:00:00 vs 00:59:59.9999967 due to the time between calls under load, but when you simplify the math: it should always be zero no matter what.
parent fdce5ff2
...@@ -65,7 +65,6 @@ public void TestBasicExpiryDateTime(bool disablePTimes, bool utc) ...@@ -65,7 +65,6 @@ public void TestBasicExpiryDateTime(bool disablePTimes, bool utc)
conn.KeyDelete(key, CommandFlags.FireAndForget); conn.KeyDelete(key, CommandFlags.FireAndForget);
var now = utc ? DateTime.UtcNow : DateTime.Now; var now = utc ? DateTime.UtcNow : DateTime.Now;
var resultOffset = utc ? TimeSpan.Zero : now - DateTime.Now;
Output.WriteLine("Now: {0}", now); Output.WriteLine("Now: {0}", now);
conn.StringSet(key, "new value", flags: CommandFlags.FireAndForget); conn.StringSet(key, "new value", flags: CommandFlags.FireAndForget);
var a = conn.KeyTimeToLiveAsync(key); var a = conn.KeyTimeToLiveAsync(key);
...@@ -81,14 +80,14 @@ public void TestBasicExpiryDateTime(bool disablePTimes, bool utc) ...@@ -81,14 +80,14 @@ public void TestBasicExpiryDateTime(bool disablePTimes, bool utc)
Assert.Null(muxer.Wait(a)); Assert.Null(muxer.Wait(a));
var time = muxer.Wait(b); var time = muxer.Wait(b);
Assert.NotNull(time); Assert.NotNull(time);
Output.WriteLine("Time: {0}, Expected: {1}-{2}", time, resultOffset + TimeSpan.FromMinutes(58), resultOffset + TimeSpan.FromMinutes(60)); Output.WriteLine("Time: {0}, Expected: {1}-{2}", time, TimeSpan.FromMinutes(59), TimeSpan.FromMinutes(60));
Assert.True(time >= resultOffset + TimeSpan.FromMinutes(58)); Assert.True(time >= TimeSpan.FromMinutes(59));
Assert.True(time <= resultOffset + TimeSpan.FromMinutes(60)); Assert.True(time <= TimeSpan.FromMinutes(60));
Assert.Null(muxer.Wait(c)); Assert.Null(muxer.Wait(c));
time = muxer.Wait(d); time = muxer.Wait(d);
Assert.NotNull(time); Assert.NotNull(time);
Assert.True(time >= resultOffset + TimeSpan.FromMinutes(88)); Assert.True(time >= TimeSpan.FromMinutes(89));
Assert.True(time <= resultOffset + TimeSpan.FromMinutes(90)); Assert.True(time <= TimeSpan.FromMinutes(90));
Assert.Null(muxer.Wait(e)); Assert.Null(muxer.Wait(e));
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment