Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
S
StackExchange.Redis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
tsai
StackExchange.Redis
Commits
8d015446
Commit
8d015446
authored
Aug 15, 2018
by
Marc Gravell
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
reinstate forgiving RedisCommandException handling *as long as* we haven't enqueued it
parent
20da3edb
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
18 additions
and
0 deletions
+18
-0
PhysicalBridge.cs
StackExchange.Redis/PhysicalBridge.cs
+18
-0
No files found.
StackExchange.Redis/PhysicalBridge.cs
View file @
8d015446
...
@@ -727,11 +727,13 @@ private WriteResult WriteMessageToServerInsideWriteLock(PhysicalConnection conne
...
@@ -727,11 +727,13 @@ private WriteResult WriteMessageToServerInsideWriteLock(PhysicalConnection conne
{
{
if
(
message
==
null
)
return
WriteResult
.
Success
;
// for some definition of success
if
(
message
==
null
)
return
WriteResult
.
Success
;
// for some definition of success
bool
isQueued
=
false
;
try
try
{
{
var
cmd
=
message
.
Command
;
var
cmd
=
message
.
Command
;
LastCommand
=
cmd
;
LastCommand
=
cmd
;
bool
isMasterOnly
=
message
.
IsMasterOnly
();
bool
isMasterOnly
=
message
.
IsMasterOnly
();
if
(
isMasterOnly
&&
ServerEndPoint
.
IsSlave
&&
(
ServerEndPoint
.
SlaveReadOnly
||
!
ServerEndPoint
.
AllowSlaveWrites
))
if
(
isMasterOnly
&&
ServerEndPoint
.
IsSlave
&&
(
ServerEndPoint
.
SlaveReadOnly
||
!
ServerEndPoint
.
AllowSlaveWrites
))
{
{
throw
ExceptionFactory
.
MasterOnly
(
Multiplexer
.
IncludeDetailInExceptions
,
message
.
Command
,
message
,
ServerEndPoint
);
throw
ExceptionFactory
.
MasterOnly
(
Multiplexer
.
IncludeDetailInExceptions
,
message
.
Command
,
message
,
ServerEndPoint
);
...
@@ -782,6 +784,7 @@ private WriteResult WriteMessageToServerInsideWriteLock(PhysicalConnection conne
...
@@ -782,6 +784,7 @@ private WriteResult WriteMessageToServerInsideWriteLock(PhysicalConnection conne
}
}
connection
.
EnqueueInsideWriteLock
(
message
);
connection
.
EnqueueInsideWriteLock
(
message
);
isQueued
=
true
;
message
.
WriteTo
(
connection
);
message
.
WriteTo
(
connection
);
message
.
SetRequestSent
();
message
.
SetRequestSent
();
...
@@ -806,6 +809,21 @@ private WriteResult WriteMessageToServerInsideWriteLock(PhysicalConnection conne
...
@@ -806,6 +809,21 @@ private WriteResult WriteMessageToServerInsideWriteLock(PhysicalConnection conne
}
}
return
WriteResult
.
Success
;
return
WriteResult
.
Success
;
}
}
catch
(
RedisCommandException
ex
)
when
(!
isQueued
)
{
Trace
(
"Write failed: "
+
ex
.
Message
);
message
.
Fail
(
ConnectionFailureType
.
InternalFailure
,
ex
,
null
);
this
.
CompleteSyncOrAsync
(
message
);
// this failed without actually writing; we're OK with that... unless there's a transaction
if
(
connection
?.
TransactionActive
==
true
)
{
// we left it in a broken state; need to kill the connection
connection
.
RecordConnectionFailed
(
ConnectionFailureType
.
ProtocolFailure
,
ex
);
return
WriteResult
.
WriteFailure
;
}
return
WriteResult
.
Success
;
}
catch
(
Exception
ex
)
catch
(
Exception
ex
)
{
{
Trace
(
"Write failed: "
+
ex
.
Message
);
Trace
(
"Write failed: "
+
ex
.
Message
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment