Remove ChannelMessageQueue.IsCompleted

Now uses ChannelMessageQueue.Completion.IsCompleted and should be consistent. Because _completion on UnboundedChannel respect no-synchronous-continuations, the old way doesn't behave as expected (IsCompleted isn't instantly set).

StackExchange.Redis.Tests/PubSub.cs

@@ -359,7 +359,7 @@ public async Task PubSubGetAllCorrectOrder()
 
                 async Task RunLoop()
                 {
-                    while (!subChannel.IsCompleted)
+                    while (!subChannel.Completion.IsCompleted)
                     {
                         var work = await subChannel.ReadAsync().ForAwait();
                         int i = int.Parse(Encoding.UTF8.GetString(work.Message));
@@ -456,7 +456,7 @@ public async Task PubSubGetAllCorrectOrder_OnMessage_Sync()
                 }
 
                 await subChannel.Completion;
-                Assert.True(subChannel.IsCompleted);
+                Assert.True(subChannel.Completion.IsCompleted);
                 await Assert.ThrowsAsync<ChannelClosedException>(async delegate
                 {
                     var final = await subChannel.ReadAsync().ForAwait();
@@ -517,7 +517,7 @@ public async Task PubSubGetAllCorrectOrder_OnMessage_Async()
                 }
 
                 await subChannel.Completion;
-                Assert.True(subChannel.IsCompleted);
+                Assert.True(subChannel.Completion.IsCompleted);
                 await Assert.ThrowsAsync<ChannelClosedException>(async delegate
                 {
                     var final = await subChannel.ReadAsync().ForAwait();

StackExchange.Redis/StackExchange/Redis/ChannelMessageQueue.cs

@@ -69,24 +69,17 @@ public sealed class ChannelMessageQueue
         public override string ToString() => (string)Channel;
 
         /// <summary>
-        /// Indicates if all messages that will be received have been drained from this channel
+        /// An awaitable task the indicates completion of the queue (including drain of data)
         /// </summary>
-        public bool IsCompleted { get; private set; }
+        public Task Completion => _queue.Reader.Completion;
 
         internal ChannelMessageQueue(RedisChannel redisChannel, RedisSubscriber parent)
         {
             Channel = redisChannel;
             _parent = parent;
             _queue = System.Threading.Channels.Channel.CreateUnbounded<ChannelMessage>(s_ChannelOptions);
-            _queue.Reader.Completion.ContinueWith(
-                (_, state) => ((ChannelMessageQueue)state).IsCompleted = true, this, TaskContinuationOptions.ExecuteSynchronously);
         }
 
-        /// <summary>
-        /// An awaitable task the indicates completion of the queue (including drain of data)
-        /// </summary>
-        public Task Completion => _queue.Reader.Completion;
-
         private static readonly UnboundedChannelOptions s_ChannelOptions = new UnboundedChannelOptions
         {
             SingleWriter = true,
@@ -165,7 +158,7 @@ public void OnMessage(Action<ChannelMessage> handler)
         private async void OnMessageSyncImpl()
         {
             var handler = (Action<ChannelMessage>)_onMessageHandler;
-            while (!IsCompleted)
+            while (!Completion.IsCompleted)
             {
                 ChannelMessage next;
                 try { if (!TryRead(out next)) next = await ReadAsync().ConfigureAwait(false); }
@@ -195,7 +188,7 @@ public void OnMessage(Func<ChannelMessage, Task> handler)
         private async void OnMessageAsyncImpl()
         {
             var handler = (Func<ChannelMessage, Task>)_onMessageHandler;
-            while (!IsCompleted)
+            while (!Completion.IsCompleted)
             {
                 ChannelMessage next;
                 try { if (!TryRead(out next)) next = await ReadAsync().ConfigureAwait(false); }