Merge pull request #71 from deepakverma/master

Cannot access a disposed object when auth fails Issue #50 and connection fails to reconnect with retry when cache is under load #65

StackExchange.Redis/StackExchange/Redis/ConnectionMultiplexer.cs

@@ -1060,7 +1060,8 @@ public void GetStatus(TextWriter log)
         internal async Task<bool> ReconfigureAsync(bool first, bool reconfigureAll, TextWriter log, EndPoint blame, string cause)
         {
             if (isDisposed) throw new ObjectDisposedException(ToString());
-
+            //if connection failed treat it as first to honor retry logic.
+            first = cause.CompareTo("connection failed") == 0 ? true : first;
             bool showStats = true;
             if (log == null)
             {
@@ -1119,7 +1120,6 @@ internal async Task<bool> ReconfigureAsync(bool first, bool reconfigureAll, Text
                         }
                     }
                 }
-
                 int attemptsLeft = first ? configuration.ConnectRetry : 1;
 
                 bool healthy = false;

StackExchange.Redis/StackExchange/Redis/PhysicalConnection.cs

@@ -523,18 +523,25 @@ static void WriteUnified(Stream stream, long value)
         void BeginReading()
         {
             bool keepReading;
-            do
+            try
             {
-                keepReading = false;
-                int space = EnsureSpaceAndComputeBytesToRead();
-                multiplexer.Trace("Beginning async read...", physicalName);
-                var result = netStream.BeginRead(ioBuffer, ioBufferBytes, space, endRead, this);
-                if (result.CompletedSynchronously)
+                do
                 {
-                    multiplexer.Trace("Completed synchronously: processing immediately", physicalName);
-                    keepReading = EndReading(result);
-                }
-            } while (keepReading);
+                    keepReading = false;
+                    int space = EnsureSpaceAndComputeBytesToRead();
+                    multiplexer.Trace("Beginning async read...", physicalName);
+                    var result = netStream.BeginRead(ioBuffer, ioBufferBytes, space, endRead, this);
+                    if (result.CompletedSynchronously)
+                    {
+                        multiplexer.Trace("Completed synchronously: processing immediately", physicalName);
+                        keepReading = EndReading(result);
+                    }
+                } while (keepReading);
+            }
+            catch(System.IO.IOException ex)
+            {
+                multiplexer.Trace("Could not connect: " + ex.Message, physicalName);
+            }
         }
         int haveReader;