This is interesting, and may explain some other hangs. Previously, arr was null, and the .Length call in the MultiBulk case was throwing a null ref. This doesn't throw externally through, it just runs forever. While there's a timeout guard against this on the ExecuteSync path, there's not on ExecuteAsync. This is easy to reproduce for example add this at the top of the result processor:

if (result.Type == ResultType.MultiBulk) throw new Exception("Woops");

...and we'll only see timeouts on sync and forever runs on async. I left this code in (commented) for an easy repro case.

/cc @mgravell

This isn't the source of our timeouts...as there aren't running. But cleaning up usages.

Turns out @mgravell really really liked "foo" and "hashset" years ago =P

ackowledge that we can timeout while waiting to get on the write queue; up the sync timeout default; rename Queue=>Write - we don't have a queue any more

TL;DR: This behaves different on a redis server running on Linux vs. Windows.

The alternative here is outright removal due to the semantics change, but we would be breaking the IProfiledCommand interface, which has a non-nullable TimeSpan member for this.

move to a shared socketmanager by default; remove existing use of SocketManager in tests - prefer the default behaviour - TODO: add explicit tests that focus on the new SocketManager reality

# Conflicts:
#	StackExchange.Redis/StackExchange/Redis/PhysicalConnection.cs

When we added the caller here, it inadvertently broke this test - quick fix.

Being removed in v2.0

fix #856 - add method to create a RedisResult that represents an array; mirrors existing factory method re single values

name the socket manager in BookSleeveTestBase; fix bug in AbandonPendingBacklog; compensate for Me() changes in AsyncTasksReportFailureIfServerUnavailable

Improve detection and error message when bad auth; still need to see why it takes 5s to timeout in my shell, though

we should probably release SE.Redis.StrongName as a type-forwarding assembly, to make the aspnet folks not hate us

# Conflicts:
#	StackExchange.Redis/StackExchange/Redis/RedisValue.cs

Useful for WSL testing Streams

When building the solution, the local ref Marc has is in the solution...this fails restore and build in CI. Adapting!

use pooled/recycled buffers for RawResult sub-items; these are never exposed outside of the framing process, so lifetime is not an issue

# Conflicts:
#	StackExchange.Redis.StrongName/StackExchange.Redis.StrongName.csproj
#	StackExchange.Redis/StackExchange.Redis.csproj
#	StackExchange.Redis/StackExchange/Redis/SocketManager.cs