- 02 Jun, 2018 4 commits
-
-
Nick Craver authored
-
Nick Craver authored
-
Nick Craver authored
So this one is fun. Windows caches DNS, including a miss. The second test runner will fail synchronously in the Socket.BeginConnect() call due to the DNS looku failing immediately (no need to wait!). This beaks our assumptions of it failing asynchronously in these tests. If this resolves the issue, we'll put a wrapper in the .BeginConnect() call to capture and recognize the SocketException "No such host is known" and return the RedisConnectionException users expect.
-
Nick Craver authored
-
- 31 May, 2018 4 commits
-
-
Nick Craver authored
-
Nick Craver authored
-
Nick Craver authored
This is on the way to v2.0 and Mono support (see #842 and #845 for discussion).
-
Nick Craver authored
This was an expedition, but here's the history: - There are 2 forks in the connection logic - One for Mono (the DnsEndpoint split, see #20 and #155) - One for .BeginConnect() and one for ConnectAsync (because netstandard1.x was "async all the things!") - There's a behind-the-scenes fork on completion type, but for actual library consumers (and not tests), it was always .Any, which was effectively .Sync. There was also a critical bug fix in #113 that unfortuantely added a lot of complexity here. The maintenance problem is this complexity wasn't even used, as far as I can tell. It was only ever exposed to even be possibly used in the test project. So we had complicated connection logic, only for the sake of testing it. Unless I'm an idiot, which is entirely possible. This commit removes that logic and simplifies things, as a first step that's a unit in itself. It does not fix Mono. There are other issues there, but thanks to WSL I can readily run the test suite under Mono on Linux now. Mono has a littany of other issues which I'll comment on in #314. The most important thing here is that we don't regress what was fixed in #113, as this doesn't readily show in tests.
-
- 30 May, 2018 3 commits
-
-
Nick Craver authored
-
Nick Craver authored
Let's see if this is a race...I'm still unable to run locally, though.
-
Nick Craver authored
-
- 29 May, 2018 2 commits
-
-
Nick Craver authored
-
Nick Craver authored
A demo of how much this saves in complexity.
-
- 28 May, 2018 6 commits
-
-
Nick Craver authored
This was an expedition, but here's the history: - There are 2 forks in the connection logic - One for Mono (the DnsEndpoint split, see #20 and #155) - One for .BeginConnect() and one for ConnectAsync (because netstandard1.x was "async all the things!") - There's a behind-the-scenes fork on completion type, but for actual library consumers (and not tests), it was always .Any, which was effectively .Sync. There was also a critical bug fix in #113 that unfortuantely added a lot of complexity here. The maintenance problem is this complexity wasn't even used, as far as I can tell. It was only ever exposed to even be possibly used in the test project. So we had complicated connection logic, only for the sake of testing it. Unless I'm an idiot, which is entirely possible. This commit removes that logic and simplifies things, as a first step that's a unit in itself. It does not fix Mono. There are other issues there, but thanks to WSL I can readily run the test suite under Mono on Linux now. Mono has a littany of other issues which I'll comment on in #314. The most important thing here is that we don't regress what was fixed in #113, as this doesn't readily show in tests.
-
Nick Craver authored
-
Nick Craver authored
-
Nick Craver authored
-
Jaap Taal authored
In unit tests mocking out an IDatabase with implementations that throw an error was not possible. Constructing the Exception instances wasn't accessible in user code. It is now.
-
Nick Craver authored
-
- 27 May, 2018 3 commits
-
-
Nick Craver authored
A lot of connections are ridiculously slow even to localhost at least in testing...let's timestamp the output (including milliseconds) so we can see what's happening.
-
Nick Craver authored
This is working as-design as ITransaction : IBatch and it's not safe in either, but adding a test to ensure it's performing correctly.
-
Andrew Kramarev authored
The article is about minIoThreads, but example use maxIoThreads
-
- 15 May, 2018 1 commit
-
-
Alison Wilbur authored
Fix indentation level on a nested list.
-
- 09 May, 2018 1 commit
-
-
Marc Gravell authored
-
- 30 Apr, 2018 1 commit
-
-
Joseph Daigle authored
Don't log details in Exception thrown by PhysicalConnection unless `IncludeDetailInExceptions` is true. (#827) fixes 822
-
- 05 Apr, 2018 2 commits
-
-
Jason Malinowski authored
The documentation for the overload of IDatabase(Async).HashSet(Async) that takes multiple fields/values was somewhat ambiguous. It could have been read to mean that fields not set as a part of the HashSetAsync are deleted rather than preserved. The documentation for HMSET was clearer, so this borrows some of the verbiage from the Redis documentation into the documentation for HashSetAsync.
-
Nick Craver authored
-
- 04 Apr, 2018 11 commits
-
-
Nick Craver authored
-
Nick Craver authored
-
Nick Craver authored
-
Marc Gravell authored
-
Nick Craver authored
-
Nick Craver authored
This takes out the global build if it throws...let's not do that.
-
Nick Craver authored
These were broght over from Booksleeve long ago and were duped.
-
Nick Craver authored
Turns out redis on Windows is hella flaky here - the test runs fine against *nix hosts - disabling for now.
-
Nick Craver authored
Fixes test runs for 2.0 and the UWP error.
-
Nick Craver authored
Branching for repro purposes...this breaks all tests runs due to UWP shenanigans.
-
Tomasz Poradowski authored
Example of setting ```minIoThreads``` configuration option for ASP.NET was not shown correctly.
-
- 23 Mar, 2018 1 commit
-
-
Nick Craver authored
There was a race here under load with the last set and the first key scan...let's not do that.
-
- 22 Mar, 2018 1 commit
-
-
Nick Craver authored
-