• Nick Craver's avatar
    Fix up boadcasts, tests, and logging across the board (#1400) · b90f991d
    Nick Craver authored
    This changes does the following:
    - Moves the broadcast to be only before the master reconfiguration to both before *and* after - a fix following https://github.com/StackExchange/StackExchange.Redis/commit/88dcf0c989b25623fb8ffb1f4d48c24593246cfe to fix the gap.
    - Tweaks tests by overall lessening runtime (and thus build server time). Overall, fixes a few static timeouts to be conditional (so they short circuit faster if met), and brings some tests that were some variant of the above into RELEASE since they're safe now.
    - Changes `UntilCondition` to take a `TimeSpan`, just because clearer. Even though I IntelliSense completed `.FromMinutes()` earlier and watched it like an idiot for a while...I stand by this decision!
    - Locks the `ITestOutputHelper` writer because...that was jacked up in races:
    
    ![off to the races](https://user-images.githubusercontent.com/454813/77232395-2f799980-6b77-11ea-8fb4-0398de25e313.png)
    
    ------
    
    Note: a lot of the test changes are just optimizations to delays which allow longer but short-circuit sooner. The important changes are in broadcast and locking around the test runner. I can think of downsides to neither, but want some @mgravell eyes. This should resolve a lot of flaky-ness with local (and build agent) tests. Not all of it, but a lot of it!
    b90f991d
Name
Last commit
Last update
.github Loading commit data...
build Loading commit data...
docs Loading commit data...
src Loading commit data...
tests Loading commit data...
toys Loading commit data...
.editorconfig Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
Build.csproj Loading commit data...
Directory.Build.props Loading commit data...
LICENSE Loading commit data...
NuGet.Config Loading commit data...
README.md Loading commit data...
Shared.ruleset Loading commit data...
StackExchange.Redis.sln Loading commit data...
StackExchange.Redis.sln.DotSettings Loading commit data...
StackExchange.Redis.snk Loading commit data...
appveyor.yml Loading commit data...
build.cmd Loading commit data...
build.ps1 Loading commit data...
global.json Loading commit data...
version.json Loading commit data...