• Nick Craver's avatar
    NRediSearch Test Suite Fixes (#1383) · 084c9c18
    Nick Craver authored
    ### NRediSearch
    - Updated module so we're testing the right thing
    - More output in the logging path for diagnosing issues
    - Remove all the `FLUSHDB` calls masking issues
    - Handle duplicate documents in latest module
    
    Note: **locally** (on WSL 2), this fixes some issues and introduces stability but *does not* fix 2 scoring issues. Suggestions are coming back with scores > 1.0, which by the documentation is not supposed to happen...so I'm not sure what should be happening here. Here's the local WSL fail:
    ```
     NRediSearch.Test.ClientTests.ClientTest.TestGetSuggestionWithScore:
      Message: 
        StackExchange.Redis.RedisCommandException : Missing required fields:  score not within range: 2.11660146713257
      Stack Trace: 
        SuggestionBuilder.Build() line 99
        Client.GetSuggestionsWithPayloadAndScores(RedisResult[] results) line 1271
        Client.GetSuggestions(String prefix, SuggestionOptions options) line 796
        ClientTest.TestGetSuggestionWithScore() line 701
    ```
    ```
    NRediSearch.Test.ClientTests.ClientTest.TestAddSuggestionGetSuggestionPayloadScores:
      Message: 
        StackExchange.Redis.RedisCommandException : Missing required fields:  score not within range: 2.71068739891052
      Stack Trace: 
        SuggestionBuilder.Build() line 99
        Client.GetSuggestionsWithPayloadAndScores(RedisResult[] results) line 1271
        Client.GetSuggestions(String prefix, SuggestionOptions options) line 796
        ClientTest.TestAddSuggestionGetSuggestionPayloadScores() line 642
    ```
    
    However, the current fixes tidy up the CI pipeline so I recommend merging this as-is, then I'll keep following up with various local errors and I'm looking at some Docker test options as alternatives to WSL2 so that people can run either.
    084c9c18
Name
Last commit
Last update
..
Aggregation Loading commit data...
QueryBuilder Loading commit data...
AddOptions.cs Loading commit data...
AggregationResult.cs Loading commit data...
AssemblyInfo.cs Loading commit data...
Client.cs Loading commit data...
Document.cs Loading commit data...
Extensions.cs Loading commit data...
InfoResult.cs Loading commit data...
Literals.cs Loading commit data...
NRediSearch.csproj Loading commit data...
Query.cs Loading commit data...
Schema.cs Loading commit data...
SearchResult.cs Loading commit data...
Suggestion.cs Loading commit data...
SuggestionOptions.cs Loading commit data...